Generate identifiers from conditions of match arms #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match arms treated same way as if arms: - For each new arm create new constraint set - Use similar logic to for loop variable initialisation. In future should have way to have some sort of union between constraints, much like env. This allows us to type check all possible execution paths.
JSAbrahams
added
enhancement: check
Codecov Report
@@ Coverage Diff @@
## develop #380 +/- ##
===========================================
+ Coverage 87.00% 87.06% +0.06%
===========================================
Files 109 109
Lines 11950 12014 +64
===========================================
+ Hits 10397 10460 +63
- Misses 1553 1554 +1
|
JSAbrahams
changed the title
Merged
JSAbrahams
commented
Dec 22, 2022
| @@ -0,0 +1,5 @@ | |||
| match 10 | |||
| n => | |||
| print("10") | |||
There was a problem hiding this comment.
What about a test where we use an undefined variable in match arm body
Also one where we shadow a variable, but use it in the same manner as we would've the outer variable (e.g. assuming it is an Int while it is a String)
There was a problem hiding this comment.
No system for the second, though this is somewhat related to #375
JSAbrahams
added a commit
that referenced
this pull request
Dec 28, 2022
* Generate ids for variables in match arm conds Match arms treated same way as if arms: - For each new arm create new constraint set - Use similar logic to for loop variable initialisation. In future should have way to have some sort of union between constraints, much like env. This allows us to type check all possible execution paths. * Test undefined variable in match arm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Match arms treated same way as if arms:
In future should have way to have some sort of union between constraints, much like env.
This allows us to type check all possible execution paths.
When we implementing pattern matching this system will need to be extended.
Added Tests
Happy
Sad
Started writing this while creating system of environment unions between match body arms.
However, I don't think that we actually want this behaviour.