Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan top-level imports and create dummy classes #379

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Scan top-level imports and create dummy classes #379

merged 2 commits into from
Dec 22, 2022

Conversation

JSAbrahams
Copy link
Owner

@JSAbrahams JSAbrahams commented Dec 22, 2022 •
edited
Loading

Relevant issues

First part of #174

Summary

In future we will need a system to get the actual signature of these classes as well.
This is a future milestone.

Added Tests

Happy

  • parse import
  • parse import alias
  • parse from import
  • parse from import alias

Sad

  • parse import with one too many alias

@JSAbrahams
Scan top-level imports and create dummy classes
a61bfeb 
In future we will need a system to get the actual
signature of these classes as well.
This is a future milestone.
@JSAbrahams
Add sad test for too many aliases
2787519
@JSAbrahams JSAbrahams added the enhancement: check New feature in the type check module label Dec 22, 2022
@JSAbrahams JSAbrahams added this to the v0.3.5 | Error handling milestone Dec 22, 2022
@JSAbrahams JSAbrahams self-assigned this Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #379 (2787519) into develop (63cc218) will increase coverage by 0.01%.
The diff coverage is 98.14%.

@@             Coverage Diff             @@
##           develop     #379      +/-   ##
===========================================
+ Coverage    87.00%   87.02%   +0.01%     
===========================================
  Files          109      109              
  Lines        11950    12004      +54     
===========================================
+ Hits         10397    10446      +49     
- Misses        1553     1558       +5
Impacted Files Coverage Δ
src/check/context/clss/generic.rs 93.15% <92.30%> (-0.04%) ⬇️
src/check/context/generic.rs 97.36% <100.00%> (+2.13%) ⬆️
src/check/context/mod.rs 95.91% <100.00%> (+1.32%) ⬆️
src/check/context/clss/mod.rs 85.81% <0.00%> (-2.84%) ⬇️

@JSAbrahams JSAbrahams marked this pull request as ready for review December 22, 2022 15:57
@JSAbrahams JSAbrahams merged commit 2c61f1d into develop Dec 22, 2022
@JSAbrahams JSAbrahams deleted the simple-dummy-imports branch December 22, 2022 17:29
@JSAbrahams JSAbrahams mentioned this pull request Dec 28, 2022
Merged
JSAbrahams added a commit that referenced this pull request Dec 28, 2022
@JSAbrahams
Scan top-level imports and create dummy classes (#379)
708b67c 
* Scan top-level imports and create dummy classes

In future we will need a system to get the actual
signature of these classes as well.
This is a future milestone.

* Add sad test for too many aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JSAbrahams JSAbrahams

Labels
enhancement: check New feature in the type check module
Projects
None yet
Milestone
v0.3.5 | Error handling
Development

Successfully merging this pull request may close these issues.
1 participant
@JSAbrahams