Emitter On/Off #2829
Merged
Emitter On/Off #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the calibration table.
…ersintel/librealsense into daversintel-emitter_onoff_and_intrinsics
daversintel
approved these changes
Dec 3, 2018
|
The changes are OK with me. But it still better to show it with the viewer. |
ev-mp
reviewed
Dec 3, 2018
src/ds5/ds5-options.cpp
Outdated
| command cmd(ds::GET_PWM_ON_OFF); | ||
| auto res = _hwm.send(cmd); | ||
| if (res.empty()) | ||
| throw invalid_value_exception("external_sync_mode::query result is empty!"); |
ev-mp
reviewed
Dec 4, 2018
| else | ||
| { | ||
| // Intrinsics not found in the calibration table - use the generic calculation | ||
| ds5_rect_resolutions resolution = res_1920_1080; |
There was a problem hiding this comment.
The generic part assumes the sensor uses FullHd for calibration with 16/9 aspect. But for other sensors, e.g. AWGC 1MP with 1280X800 16/10 aspect ratio it will produce distortions during uv mapping, for instance.
There was a problem hiding this comment.
We can add the code to validate entry for res_1920_1080 and throw exception if the entry is not used for calibration or not valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2699
@daversintel please review and comment if my proposed changes are acceptable:
experimentalpredicate onfirmware_version, to for now only allow this feature for firmware versions that support it.RS2_OPTION_EMITTER_ON_OFFfor simplicity.