Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleWeatherService: Add forecast operator overrides #2011

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

vkareh
Copy link
Contributor

@vkareh vkareh commented Feb 10, 2024

Any screen that relies on DirtyValue to display up-to-date forecast data would require the struct to provide an operator override for comparison.

Any screen that relies on DirtyValue to display up-to-date forecast data
would require the struct to provide an operator override for comparison.
Copy link

Build size and comparison to main:

Section Size Difference
text 373108B -16B
data 940B 0B
bss 63516B 0B

@NeroBurner NeroBurner added the weather Bugs and PRs related to Weather label Feb 10, 2024
@NeroBurner NeroBurner added this to the 1.15.0 milestone Feb 10, 2024
@NeroBurner NeroBurner merged commit 2db9205 into InfiniTimeOrg:main Feb 10, 2024
7 checks passed
@vkareh vkareh deleted the weather-forecast-op-overrides branch February 12, 2024 14:30
lasnikr pushed a commit to lasnikr/LasnikrInfiniTime that referenced this pull request Mar 5, 2024
…2011)

Any screen that relies on DirtyValue to display up-to-date forecast data
would require the struct to provide an operator override for comparison.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
weather Bugs and PRs related to Weather
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants