Show alarm controller state in status icons #1884
Conversation
|
Build size and comparison to main:
|
There was a problem hiding this comment.
I like this feature! :)
You should be very safe to test this on a sealed device (speaking from experience).
If something goes wrong, which shouldn't happen, you can always:
- reboot to get back to your last firmware (don't verify your debug flash of course)
- hold the button pressed until the color changed twice during boot to get to the fallback firmware and update your watch from there.
|
I have also tested the feature on hardware. |
|
I like this, but I think the icon has a little too much filled space and the simple circle isn’t as defined as a more standard alarm icon: |
|
I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon. I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request. |
|
Ah, I forgot it was already the icon for the alarm app.
Sorry about that.
…On November 9, 2023 9:30:26 AM CST, Jozef Mlich ***@***.***> wrote:
I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon.
I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request.
--
Reply to this email directly or view it on GitHub:
#1884 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
|
This should be rebased against |
|
@jmlich I'd like to give this change a try, would you mind rebasing this changeset against the current state of |
jmlich
force-pushed
the
main
branch
2 times, most recently
from
54190ac to
f0e01cb
Compare
|
Rebased to recent main |
jmlich
force-pushed
the
main
branch
5 times, most recently
from
15fb52c to
e2ff1b2
Compare
|
Rebased to recent main. The screenshot and screencast in pull request description was updated as well. |
I would like to know if the alarm is active on Watch Face Digital screen.
I made an prototype with InfiniSim and it looks that it works as expected:
However, I have only sealed version of PineTime and this is my first attempt to make something for embedded device. I will be happy if someone can check if this actually works on real device. I am looking forward for your feedback.