Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/version fixup #92

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Feature/version fixup #92

merged 3 commits into from
Oct 14, 2022

Conversation

davidorme
Copy link
Collaborator

Description

The package version in virtual_rainforest.__version__ now tracks the version set by poetry in pyproject.toml

Fixes #90

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@davidorme davidorme requested a review from alexdewar October 14, 2022 15:50
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dalonsoa
Copy link
Collaborator

But what about the documentation? Can you get the version in Sphinx the same way?

@davidorme
Copy link
Collaborator Author

Oddly, that failure didn't happen when running pytest locally. I don't know why the local mypy didn't go looking in the docs tree. I've updated conf.py to use the new API for the version number and all should be well.

@davidorme davidorme merged commit 5eaebbd into develop Oct 14, 2022
@davidorme davidorme deleted the feature/version_fixup branch October 14, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package version is multiply defined
2 participants