Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #456

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Update PULL_REQUEST_TEMPLATE.md #456

merged 2 commits into from
Jun 27, 2024

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Jun 27, 2024

We discussed in a group meeting that we want to add an extra check that reminds developers to review and update documentation when necessary. This PR adds a check to the PR template.

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (193f257) to head (418da10).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #456   +/-   ##
========================================
  Coverage    94.75%   94.75%           
========================================
  Files           70       70           
  Lines         3791     3791           
========================================
  Hits          3592     3592           
  Misses         199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And me.

@vgro vgro merged commit 327ad85 into develop Jun 27, 2024
12 checks passed
@vgro vgro deleted the vgro-patch-1 branch June 27, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants