Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/matric potential #320

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Feature/matric potential #320

merged 2 commits into from
Sep 29, 2023

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Sep 28, 2023

This PR adds a function that converts soil moisture into matric potential. It is very oversimplified and not parameterized properly at the moment but hopefully enough to be used by the soil model.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@vgro vgro requested a review from jacobcook1995 September 28, 2023 14:52
@codecov-commenter
Copy link

Codecov Report

Merging #320 (889ba92) into develop (78b18b5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #320      +/-   ##
===========================================
+ Coverage    96.50%   96.52%   +0.01%     
===========================================
  Files           48       48              
  Lines         2376     2388      +12     
===========================================
+ Hits          2293     2305      +12     
  Misses          83       83              
Files Coverage Δ
...irtual_rainforest/models/hydrology/below_ground.py 100.00% <100.00%> (ø)
virtual_rainforest/models/hydrology/constants.py 100.00% <100.00%> (ø)
...ual_rainforest/models/hydrology/hydrology_model.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgro vgro merged commit 1bd1a0d into develop Sep 29, 2023
@vgro vgro deleted the feature/matric_potential branch September 29, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants