Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect litter pools to soil pools #281

Merged
merged 13 commits into from
Aug 7, 2023

Conversation

jacobcook1995
Copy link
Collaborator

Description

This pull request connects the litter pools to the soil pools, so that when litter decays a fraction of it enters the soil. I've also added to the example data so that the litter model can be run as part of vr_run.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@jacobcook1995 jacobcook1995 requested review from alexdewar and vgro August 7, 2023 08:52
Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've given this a quick once-over and it seems sensible to me. I'm a little lost on the science here though, so I'm not really able to give a more in-depth review.

@jacobcook1995
Copy link
Collaborator Author

Ahh cheers @alexdewar, I've been adding you and Diego to fairly sciencey pull requests mainly because I want to check that bad code style isn't creeping in, so a once over to check that there isn't anything glaringly bad is very helpful!

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #281 (2694c07) into develop (7c97493) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #281   +/-   ##
========================================
  Coverage    94.25%   94.26%           
========================================
  Files           47       47           
  Lines         1915     1917    +2     
========================================
+ Hits          1805     1807    +2     
  Misses         110      110           
Files Changed Coverage Δ
virtual_rainforest/models/litter/litter_model.py 100.00% <ø> (ø)
virtual_rainforest/models/soil/carbon.py 100.00% <ø> (ø)
virtual_rainforest/models/soil/constants.py 100.00% <ø> (ø)
virtual_rainforest/models/soil/soil_model.py 100.00% <ø> (ø)
virtual_rainforest/models/litter/constants.py 100.00% <100.00%> (ø)
virtual_rainforest/models/litter/litter_pools.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm also not very familiar with the soil carbon science, but the general approach looks sensible :-)

@jacobcook1995 jacobcook1995 merged commit 6538154 into develop Aug 7, 2023
@jacobcook1995 jacobcook1995 deleted the feature/connect_litter_to_soil branch August 7, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants