-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect litter pools to soil pools #281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've given this a quick once-over and it seems sensible to me. I'm a little lost on the science here though, so I'm not really able to give a more in-depth review.
Ahh cheers @alexdewar, I've been adding you and Diego to fairly sciencey pull requests mainly because I want to check that bad code style isn't creeping in, so a once over to check that there isn't anything glaringly bad is very helpful! |
Codecov Report
@@ Coverage Diff @@
## develop #281 +/- ##
========================================
Coverage 94.25% 94.26%
========================================
Files 47 47
Lines 1915 1917 +2
========================================
+ Hits 1805 1807 +2
Misses 110 110
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm also not very familiar with the soil carbon science, but the general approach looks sensible :-)
Description
This pull request connects the litter pools to the soil pools, so that when litter decays a fraction of it enters the soil. I've also added to the example data so that the litter model can be run as part of
vr_run
.Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks