Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a super simple stream flow equation to the hydrology model: Q=P-ET-dS . This requires the plant model to run first, but as the p-model does currently not need soil moisture as an input, that should work. I added ET to the dummy plant data set and made a small adjustment to the input precipitation. Once we add p-hydro or SPLASH, we will have to rejig this; maybe split the stream flow from the hydrology model.
For now, the new features gives us the stream flow Q for each grid cell which can then in a next step be summed up for the whole area or catchments within the study area.
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks