Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add streamflow #262

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Feature/add streamflow #262

merged 8 commits into from
Jul 27, 2023

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Jul 26, 2023

This PR adds a super simple stream flow equation to the hydrology model: Q=P-ET-dS . This requires the plant model to run first, but as the p-model does currently not need soil moisture as an input, that should work. I added ET to the dummy plant data set and made a small adjustment to the input precipitation. Once we add p-hydro or SPLASH, we will have to rejig this; maybe split the stream flow from the hydrology model.
For now, the new features gives us the stream flow Q for each grid cell which can then in a next step be summed up for the whole area or catchments within the study area.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@vgro vgro requested a review from jacobcook1995 July 26, 2023 15:06
Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgro vgro merged commit fb7b468 into develop Jul 27, 2023
@vgro vgro deleted the feature/add_streamflow branch July 27, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants