-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/correct dummy climate #254
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #254 +/- ##
========================================
Coverage 95.04% 95.04%
========================================
Files 42 42
Lines 1694 1694
========================================
Hits 1610 1610
Misses 84 84
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Had a one minor comment.
|
||
The standard output unit of ERA5-Land temperatures is Kelvin which we need to convert | ||
to degree Celsius for the Virtual Rainforest. This includes `2m air temperature` and | ||
`2m dewpoint temperature` which are used to calculate relative humidity in next step. | ||
to degree Celsius for the Virtual Rainforest. This includes 2m air temperature and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth switching from "m" to "meters" here, as you do that in the section below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only changed it in the next section because it looked funny on its own without a number, here it is used as a unit.
I discovered some issues with the 2m temperature in the dummy climate data set and updated the documentation. I also changes the input precipitation from m to mm.
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks