Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/correct dummy climate #254

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Feature/correct dummy climate #254

merged 3 commits into from
Jul 12, 2023

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Jul 11, 2023

I discovered some issues with the 2m temperature in the dummy climate data set and updated the documentation. I also changes the input precipitation from m to mm.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@vgro vgro requested a review from jacobcook1995 July 11, 2023 16:13
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #254 (b0374c0) into develop (67ac3f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #254   +/-   ##
========================================
  Coverage    95.04%   95.04%           
========================================
  Files           42       42           
  Lines         1694     1694           
========================================
  Hits          1610     1610           
  Misses          84       84           
Impacted Files Coverage Δ
...l_rainforest/models/abiotic_simple/microclimate.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Had a one minor comment.


The standard output unit of ERA5-Land temperatures is Kelvin which we need to convert
to degree Celsius for the Virtual Rainforest. This includes `2m air temperature` and
`2m dewpoint temperature` which are used to calculate relative humidity in next step.
to degree Celsius for the Virtual Rainforest. This includes 2m air temperature and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth switching from "m" to "meters" here, as you do that in the section below

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only changed it in the next section because it looked funny on its own without a number, here it is used as a unit.

@vgro vgro merged commit 202baad into develop Jul 12, 2023
@vgro vgro deleted the feature/correct_dummy_climate branch July 12, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants