Feature/separate hydrology

[vgro]

I moved the hydrology (soil moisture and runoff) out of the abiotic_simple_model to a new model (hydrology_model) to make it easier to plug in different (external) hydrology models that might have different levels of complexity and different time steps; for example HydroPy, SPLASH, WSIMOD. The functions are the same as before, just in a separate model. This means that the hydrology initializes the soil_moisture variable which the soil model depends on, so has to come before that.

In the course of this, I renamed the simple_regression module to microclimate as this is more descriptive of what is going on there.

There are still some features missing: the vertical (downward) flow, the subsurface flow, the horizontal flow between grid cells, the stream flow and the extraction of water by plant roots (=evapotranspiration). This will be implemented step by step after discussion with group members as it requires some thinking about the order of processes.

Question: The equation at the end of hydrology_model does not show in the online documentation, any suggestions why this could be?

Type of change

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist

• Make sure you've run the pre-commit checks: $ pre-commit run -a
• All tests pass: $ poetry run pytest

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[jacobcook1995]

Looks like a sensible restructure to me! I've added a few minor comments, but nothing major really

[dalonsoa]

This looks really good - and definitely the refactoring makes sense now that the codebase an d potential use is growing. Excellent use of some of xarray capabilities.

I'm not sure on the question about the documentation. What equation does not show?

[vgro]

This looks really good - and definitely the refactoring makes sense now that the codebase an d potential use is growing. Excellent use of some of xarray capabilities.

I'm not sure on the question about the documentation. What equation does not show?

Thank you for the positive feedback.
We solved the issue with the documentation, @jacobcook1995 came across a similar problem before and had a solution.

[davidorme]

LGTM too.