Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setup step to main function flow #227

Merged
merged 1 commit into from
May 30, 2023

Conversation

jacobcook1995
Copy link
Collaborator

Description

This adds a setup step to the main function flow (which the abiotic_simple model needs to run correctly). This was added in before but seems to have been overwritten (potentially due to bad git merging on my part).

There's no testing of it as it's pretty hard to test things in vr_run in a sane manner.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@jacobcook1995 jacobcook1995 requested a review from vgro May 30, 2023 11:56
Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobcook1995 jacobcook1995 merged commit 905dade into develop May 30, 2023
@jacobcook1995 jacobcook1995 deleted the feature/add_setup_step branch May 30, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants