Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated defaults for core config options to match dummy data #226

Merged
merged 1 commit into from
May 30, 2023

Conversation

jacobcook1995
Copy link
Collaborator

Description

This PR just changes the default config options for the core module to match the dummy datasets we are using for the dummy module.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • [N/A] Tests added that prove fix is effective or that feature works

@jacobcook1995 jacobcook1995 requested a review from vgro May 30, 2023 10:31
Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@codecov-commenter
Copy link

Codecov Report

Merging #226 (151c1ce) into develop (5ca2055) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #226      +/-   ##
===========================================
+ Coverage    95.18%   95.41%   +0.23%     
===========================================
  Files           35       36       +1     
  Lines         1494     1549      +55     
===========================================
+ Hits          1422     1478      +56     
+ Misses          72       71       -1     
Impacted Files Coverage Δ
...rtual_rainforest/models/abiotic_simple/__init__.py 100.00% <ø> (ø)
virtual_rainforest/core/data.py 88.60% <100.00%> (+0.44%) ⬆️
...rest/models/abiotic_simple/abiotic_simple_model.py 100.00% <100.00%> (+1.58%) ⬆️
...nforest/models/abiotic_simple/simple_regression.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobcook1995 jacobcook1995 merged commit d132ad8 into develop May 30, 2023
@jacobcook1995 jacobcook1995 deleted the feature/update_core_defaults branch May 30, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants