Feature/split testing #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r bug in vr.core.config.py
…tual files not needed
|
In addition to restructuring the test files to match the code directory structure, this also reorganises the test data files, merging the |
vgro
approved these changes
Feb 13, 2023
tests/core/test_model.py
Outdated
| """Test module for model.py (and associated functionality). | ||
|
|
||
| This module tests the functionality of model.py, as well as other bits of code that | ||
| define models based on the class defined in model.py |
There was a problem hiding this comment.
would you like to add here {MODEL_NAME}_model.py? Or mention that this is a general test for the model?
There was a problem hiding this comment.
Yeah that bit definitely could be clearer. I've tried to clarify that this script tests model.py which is the script that provides the framework that other specific models (e.g. abiotic_model.py) have to follow
7 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test files have now been split such that their structure mirrors the structure of the package code. This PR also changes the name of the model specific
model.pyto{MODEL_NAME}_model.pyto make things a bit clearer.Fixes #166
Fixed #168
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks