Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_preprocessing ERA5 and CDS examples #139

Merged
merged 17 commits into from
Jan 10, 2023
Merged

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Jan 6, 2023

Description

I added a section on how to download climate data from the CDS and some simple preprocessing.
At the moment, only the ERA5 file shows the correct sidebar, I don't know where I need to include this to set out the structure properly.

Also, the jupiter notebook is not running and I don't know why exactly(apparently, it cannot find xarray, I think it might be earlier on).

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • [-] All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • [-] Tests added that prove fix is effective or that feature works

@vgro vgro requested a review from davidorme January 6, 2023 14:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #139 (3ccd167) into develop (9b2fb9b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #139   +/-   ##
========================================
  Coverage    94.06%   94.06%           
========================================
  Files           11       11           
  Lines          472      472           
========================================
  Hits           444      444           
  Misses          28       28           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some minor things to fix up.

vgro and others added 12 commits January 9, 2023 10:55
typo corrected

Co-authored-by: David Orme <davidorme@users.noreply.github.com>
equation syntax changed

Co-authored-by: David Orme <davidorme@users.noreply.github.com>
typo corrected

Co-authored-by: David Orme <davidorme@users.noreply.github.com>
shorter titles in index menu

Co-authored-by: David Orme <davidorme@users.noreply.github.com>
@vgro vgro requested a review from davidorme January 9, 2023 13:31
@vgro vgro marked this pull request as draft January 9, 2023 14:00
Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vgro vgro marked this pull request as ready for review January 10, 2023 09:35
@vgro vgro merged commit 40983f8 into develop Jan 10, 2023
@vgro
Copy link
Collaborator Author

vgro commented Jan 10, 2023

First set of recipes to download and preprocess climate data. The location for this code and dummy data set will likely change in the future, there might be a separate package for pre-processing that includes topographic adjustment and scaling from low to high resolution (100 m).

@vgro vgro deleted the feature/climate_data_doc branch January 10, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants