Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to matplotlib (or wrap in try except) #41

Merged
merged 20 commits into from
Nov 25, 2019
Merged

Remove calls to matplotlib (or wrap in try except) #41

merged 20 commits into from
Nov 25, 2019

Conversation

ngoiz
Copy link
Contributor

@ngoiz ngoiz commented Nov 25, 2019

Following on from #37, this removes unnecessary calls to matplotlib. In those parts where matplotlib is useful for debugging or for results presentation, it is wrapped in a try:, except: such that a warning is issued if matplotlib is not found. This will be useful when using /utils/environment_minimal.yml that does not include matplotlib by default.

ngoiz and others added 20 commits November 19, 2019 13:53
@ngoiz
Fixed issue with images in the case file docs + minor improvements
1bbfa4d
@ngoiz
Remove from excluded list of docs sharpy.linear
10f2e0e
@ngoiz
test new paths in docs
16d8aa3
@ngoiz
A few tests in the docs to import failing postprocs
2259c79
@ngoiz
Attempt to fix RTD after destruction
97b0314
@ngoiz
Fixed a number of warnings in docs due to poor RTD format
52129ef
@ngoiz
Fixed some RTD warnings
6aaac22
@ngoiz
Fixes #32 - numpy arrays removed from default settings values
3d28ecd
@fonsocarre
Merge pull request #31 from ImperialCollegeLondon/dev_doc
929a2da 
Improvements in documentation
@ngoiz
A few comments on gusts and linear
6667b2b
@ngoiz
Default settings now transformed to the settings_types rather than copy
f80ce1b
@ngoiz
Added a short explanation on how to create the SHARPy settings
6be8f68
@ngoiz
Added the documentation for PreSharpy and changed settings to new format
a48c0d3
@fonsocarre
Merge pull request #34 from ImperialCollegeLondon/dev_doc
7174829 
Default settings get type specified for the setting rather than their own type
@ngoiz
Removes Theodorsen case from cases
ea608d2
@ngoiz
Removes geo_utils from templates (incorporated in utilities)
b618680
@ngoiz
Removes rotating case from cases (deprecated) - see WT cases for example
a63221c
@ngoiz
Removed deprecated frequency response plot
d8a6188
@ngoiz
Try except matplotlib in freqresponse post processor
b1991c5
@ngoiz
Removed all matplotlib imports from the code and/or wrapped in try, expt
9f6f855
@ngoiz ngoiz requested a review from fonsocarre November 25, 2019 17:16
@fonsocarre fonsocarre merged commit 85bf41f into master Nov 25, 2019
@fonsocarre fonsocarre deleted the remove_matplotlib branch November 25, 2019 19:04
@ngoiz ngoiz restored the remove_matplotlib branch November 26, 2019 13:43
@ngoiz ngoiz deleted the remove_matplotlib branch November 26, 2019 14:18
@fonsocarre fonsocarre mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fonsocarre fonsocarre Awaiting requested review from fonsocarre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngoiz @fonsocarre