bringing commits to main into develop #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add cs type to allow deflection control via external controller - use different flap ids for right and left wing, because in the linear model they deflect in different directions - add hinge coord to avoid failure in linearization
- add input settings for number of control surfaces instead of getting number from number of inputted intital deflection values
- causes problem with iostream of jupyter notebook
- export simulink model to be accesible from older matlab versions too (2021a)
- also includes minor documentation adjustments
- causes error in unittest in pazy tests due to renaming and type change
- enables the matlab script execution without the need to have a Matlab desktop version (e.g. virtual machines)
Fixed some formatting errors and added further clarification to some steps.
Fixed one more typo and added further clarification about any times mentioned.
…ng code In a previous commit, the input type of the initial cs deflection (from float back to list of floats/ints) has been changed to avoid unittest issues and the updated type makes more sense. The code for closed loop simulation has to be adjusted now as well (instead of list, only give one number to the cilent) as control surfaces are symmetric. Further, float type initial value is enforced in client script, to avoid type errors when creating binary control input message containing control surface deflections.
…ng code In a previous commit, the input type of the initial cs deflection (from float back to list of floats/ints) has been changed to avoid unittest issues and the updated type makes more sense. The code for closed loop simulation has to be adjusted now as well (instead of list, only give one number to the cilent) as control surfaces are symmetric. Further, float type initial value is enforced in client script, to avoid type errors when creating binary control input message containing control surface deflections. This commit also includes the removal of code giving instructions of executing the matlab script from Matlab's Desktop version. Only, Matlab's engine API for Python is recommended here as it can be run within the same document.
Small additions to the installation guide.
Tutorial for closed-Loop Simulation with SHARPy as a hardware-in-the-loop system
- convert normalized open-loop tip deflection to percent and not in plotting funcition because it is reused later - update fixed result graphs
Codecov Report
@@ Coverage Diff @@
## develop #244 +/- ##
===========================================
- Coverage 67.20% 67.20% -0.01%
===========================================
Files 156 156
Lines 25924 25923 -1
===========================================
- Hits 17423 17422 -1
Misses 8501 8501
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
several commits where made directly to main and develop is now behind