Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARPy Docker now releases to GitHub Packages #218

Merged
merged 27 commits into from
May 31, 2023
Merged

SHARPy Docker now releases to GitHub Packages #218

merged 27 commits into from
May 31, 2023

Conversation

ngoiz
Copy link
Contributor

@ngoiz ngoiz commented Oct 21, 2022

Release SHARPy Docker image automatically to GitHub Packages

This is done in a CI workflow through a new GitHub action. Master, release and old versions docker images of SHARPy should appear in the Packages page of the repo. The installation instructions have been amended to show how to download the image and build a container. The Dockerfile has been amended to install SHARPy through pip, as introduced in v2.0.

A minor update is the change of how we store SHARPy's version. I have added an argument such that you can query the code version through sharpy --version and stored the version in sharpy/version.py which should be the one version of truth and only file that needs modification once a new release is ready.

@ngoiz
Copy link
Contributor Author

ngoiz commented Oct 23, 2022

Added some modifications such that the Docker image is only published if it is a push to master, develop or an annotated version tag starting as v*. For pull requests, it builds the image but does not published. Once this is merged into develop, the job test_image_build should be added as a required check to the currently protected branches

@ngoiz ngoiz requested review from kccwing and ACea15 November 10, 2022 13:11
@kccwing
Copy link
Collaborator

kccwing commented Nov 10, 2022

Hello @ngoiz , thanks for updating the docker image and the automatic github action to generate these! We aim plan to switch over to a much simpler environment.yml file as part of the upgrade from py3.7 to 3.10, in #222 from @ACea15 (environment_new.yml), and hence will merge #217 and #222, then this, then switching to master as the default branch, then a new version.

@kccwing kccwing merged commit 7aa139b into develop May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants