-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation settings check - Unrecognised settings raise Error #148
Conversation
- add output function to base class to reuse in child classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work and thanks for the useful contribution to SHARPy! I have just added a minor change to exceptions.py to avoid some duplicate code. The rest looks good to me!
Codecov Report
@@ Coverage Diff @@
## develop #148 +/- ##
===========================================
+ Coverage 61.70% 61.83% +0.12%
===========================================
Files 124 123 -1
Lines 22508 22479 -29
===========================================
+ Hits 13889 13900 +11
+ Misses 8619 8579 -40
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the contributions!
Big functionality check with SHARPy checking that the simulation settings are correct or else raising an error. This feature is implemented with 2 main objectives in mind:
Since it has been a collective effort getting all of this updated, please could you all have a look (obviously at files you personally haven't modified :) ). Thanks for all the work getting all those legacy cases and examples up to date!