Fix bug: Additional Empty Sheet Issue in Column Metadata

[N-thony]

@rdstern, I don't remember the issue number. But this fixes the issue when opening the column metadata window it comes with an additional empty sheet named Sheet1

[rdstern]

It is certainly mentioned in issue #9351. Let me check.

[rdstern]

@N-thony I think some bits are fixed, but I still get this!

a) It has still added the Sheet1.
b) It shouldn't be here anyway, because I opened the file - first one from extRemes package, and then pressed to go to the Log/Script - why is it asking about metadata then?

[N-thony]

@N-thony I think some bits are fixed, but I still get this!

a) It has still added the Sheet1. b) It shouldn't be here anyway, because I opened the file - first one from extRemes package, and then pressed to go to the Log/Script - why is it asking about metadata then?

@rdstern have a look again

[rdstern]

@N-thony that's much better. It now works fine when I go into the log/script window.
Then I tried getting the column metadata, and the extra Sheet1 is still there. However, I then clicked Yes, and when the metadata finally appeared, I was happy to see that Sheet1 is no longer there. So that's no longer a particular problem. (So far I could call that a feature!

Let me test some more options.
a) I tried adding the data frame meta-data window, instead of the log-script window. That worked fine and also did not ask anything about the column metadata - which is good. It shouldn't!
b) Then I tried switching the data and column metadata. Now it should have asked me, but instead here is the result:

I also noticed an oddity in the view menu, that I never noticed before:

The Column Metadata has now moved to the top of the View menu. I didn't even know items could move, in the menus, and would prefer they didn't.

Then I tried volunteering for the column metadata. Now I correctly got the warning message and accepted. This gave another issue, that may be easy to fix, or may be done separately. Namely it does take a long time, which I understand - but it doesn't show the warning screen that it is still working away. So it looks as though R-Instat has frozen. Could the message be added?

When it loaded the metadata I could make the switch in windows, and all was fine, and quick. The order of items in the metdata was still changed. But no hint now of Sheet1

It is certinly better than before. Will you attack some of the above, or should I approve and the other bits come later?

[N-thony]

@rdstern I will address the above points in this PR, it needs to be done more carefully.

[rdstern]

@N-thony should I approve so the current improvements get into this version?

[N-thony]

@N-thony should I approve so the current improvements get into this version?

@rdstern, yes.

[rdstern]

Approving in the hope it can be included in the forthcoming release.
@Patowhiz please do a final check and merge

[Patowhiz]

@N-thony will merge this after the conflicts are resolved.

[N-thony]

@N-thony will merge this after the conflicts are resolved.

Done

[Patowhiz]

@rdstern once you test and approve this I'll merge.

[rdstern]

@N-thony I think it is alright now: I still get this:

But after saying yes, the metadata appears without that extra sheet. I think it is ok now.
@Patowhiz back to you to merge.

[Patowhiz]

@rdstern do you want this to be merged as it is or you want @N-thony to fix the message issue? Is it an issue on this PR only or also in the master?

[rdstern]

@Patowhiz I am ok for it to me merged as it is.

[Patowhiz]

Approving as requested by @rdstern