Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug in Define Climatic Loading and Address Usability Inconvenience #9389

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

N-thony
Copy link
Collaborator

@N-thony N-thony commented Jan 24, 2025

Fixes #9388
@rdstern, I was not able to reproduce the error you have reported in the issue but I have tried to improve here the time when loading the dialogue.

@rdstern
Copy link
Collaborator

rdstern commented Jan 24, 2025

@N-thony I think it is quicker, but the error message remains. It is the second time I go into the dialog, and it is still looking for the previous data frame.

image

I found it by
a) starting with the Zambia Eastern data
b) and going into the Define climatic. Accepting and pressing Ok.
c) Then I used file Close data book
d) Then Opened Moorings
e) Then used Dates > Use Date and added the day of year, and day of month.
f) Then Define Climatic gives the error above. It is still expecting the Zambia data.

@N-thony
Copy link
Collaborator Author

N-thony commented Jan 24, 2025

@rdstern have a look now

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-thony good to have found that as well as improving the code. Thanks
@Patowhiz over to you to check and hopefully merge

@rdstern
Copy link
Collaborator

rdstern commented Feb 19, 2025

@Patowhiz could you please check and merge

@Patowhiz Patowhiz merged commit 706e61d into IDEMSInternational:master Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A bug loading the Define Climatic and also a possible inconvenience.
3 participants