Fixed bug with with ordered factors #9344
Conversation
There was a problem hiding this comment.
@Vitalis95 excellent. Could you say anything about how that one-variable regression happened?
If you have time for a cosmetic change then I note that when a table is produced it has escaped our editing and still says Save Table, rather than Store Table. That's both for 2 way and 3 way.
But, if not then that can be done later.
@N-thony I am approving and with the bug fix, we must merge this, before producing the version today. I am very releived it is fixed.
instat/ucrReceiverMultiple.vb
Outdated
| @@ -413,6 +413,8 @@ Public Class ucrReceiverMultiple | |||
| For i As Integer = 0 To strDataTypes.Count - 1 | |||
| If strDataTypes(i).Contains("factor") OrElse strDataTypes(i).Contains("character") Then | |||
There was a problem hiding this comment.
@Vitalis95, how about this?
If strDataTypes(i).Contains("factor") OrElse strDataTypes(i).Contains("character") OrElse strDataTypes(i).Contains("ordered,factor") Then
instat/ucrReceiverMultiple.vb
Outdated
| ElseIf strDataTypes(i).Contains("ordered") Then | ||
| strDataTypes(i) = "categorical" |
|
@rdstern , the multiple receiver in One > Variable was not setting the R code properly |
Fixes #9328
@rdstern @N-thony , I noticed that the issue also affects other dialogs, such as the Replace Values dialog.