Displaying multi-line comments better, from scripts #9337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
reviewed
Jan 8, 2025
There was a problem hiding this comment.
@N-thony great, I am happy to approve.
I just wonder whether the same change would improve the display of code in the Insert > Library dialog?
That's much less important, and may even make it worse, but I think it would be good. I am happy to leave it, and approve now, if not trivial, but wonder?
rdstern
changed the title
Patowhiz
requested changes
Jan 9, 2025
Patowhiz
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
@rdstern this now looks good. Could you please retest it with both comments and scripts enabled, as well as with only comments enabled? Also test with scripts coming from dialogs. If it meets your expectations, feel free to approve, and I will proceed with merging.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9327
@rdstern, I hope this solve the issue as mentioned. Have a look