-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes importing of Climsoft observation data using station names #9137
Fixes importing of Climsoft observation data using station names #9137
Conversation
updated my master
updated my master
updated the tables branch from master
updated my master
@Patowhiz looks good to me. I'm not sure how to test your correction, but the menu changes look fine. Then @N-thony can you check also and approve as soon as possible. It would be good to merge today, or tomorrow, as it makes changes to the main code. |
@rdstern I've removed the 4.2.2 and added the help ids. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. @N-thony over to you to check and hopefully merge?
instat/frmMain.Designer.vb
Outdated
Me.Text = "R-Instat " + My.Application.Info.Version.Major.ToString + "." + | ||
My.Application.Info.Version.Minor.ToString + "." + | ||
My.Application.Info.Version.Build.ToString | ||
Me.Text = "R-Instat .." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put back the version number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-thony this is quite interesting, I didn't change the title text at all. I have now reverted the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-thony, now I understand why it changed itself. And it would keep changing whenever design changes are done.
This kind of 'advanced' concatenation is besy done in the code file, not the designer file. Would be good if this is done in separate PR, I'm assuming you are aware of when this was added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that will solve this issue of reverting the version number. If you are happy to open a new issue about then I will assign it to @derekagorhom for the quick change.
@rdstern back to you |
Fixes #6986.
@rdstern this is ready for review.
This should now be able to import observations using station names that have apostrophes as well.
I've also changed the dialog title to show the version that the dialog is compatible with.
I've also removed the climsoft wizard menu item.