Adding File > Import from Open App Builder dialog #9121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Vitalis95 two minor changes: 1. Switched the TRUE and FALSE around for the ucrChkFilter and changed the default to be FALSE 2. Switched the parameter names in the final sub as they were the wrong way around
lilyclements
previously approved these changes
Sep 5, 2024
N-thony
requested changes
Sep 5, 2024
instat/frmMain.Designer.vb
Outdated
| Me.Controls.Add(Me.splOverall) | ||
| Me.Controls.Add(Me.stsStrip) | ||
| Me.Controls.Add(Me.Tool_strip) | ||
| Me.Controls.Add(Me.mnuBar) | ||
| Me.Icon = CType(resources.GetObject("$this.Icon"), System.Drawing.Icon) | ||
| Me.IsMdiContainer = True | ||
| Me.MainMenuStrip = Me.mnuBar | ||
| Me.Margin = New System.Windows.Forms.Padding(4, 4, 4, 4) | ||
| Me.Name = "frmMain" | ||
| Me.Text = "R-Instat .." |
There was a problem hiding this comment.
can you add back the version number?
instat/sdgImportFromClimSoft.vb
Outdated
Comment on lines
195
to
201
| 'Private Sub ucrInputDrv_ControlValueChanged(ucrChangedControl As ucrCore) Handles ucrInputDrv.ControlValueChanged | ||
| ' If Not ucrInputDrv.IsEmpty Then | ||
| ' clsRDatabaseConnect.AddParameter("drv", ucrInputDrv.GetText, iPosition:=4) | ||
| ' Else | ||
| ' clsRDatabaseConnect.RemoveParameterByName("drv") | ||
| ' End If | ||
| 'End Sub |
|
@N-thony over to you |
lilyclements
approved these changes
Sep 5, 2024
N-thony
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9099
@lilyclements , @N-thony , this is ready for review