Ensured output from Rating Data dialog is correct #8108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloyddewit
requested changes
Feb 7, 2023
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
|
@lloyddewit i have made the changes, thank you |
lloyddewit
previously approved these changes
Feb 8, 2023
There was a problem hiding this comment.
@derekagorhom Thanks for the tidy/readable code, looks good to me
|
@berylwaswa if you can test/approve, then we can merge, thanks |
|
@derekagorhom this looks good, even the ok is disabled when no name is given. |
lloyddewit
approved these changes
Feb 8, 2023
lloyddewit
changed the title
lloyddewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes partly #8104
@Patowhiz , @lloyddewit , @N-thony
This PR is ready for review