Ensured that the selected sheet in the Data View is maintained after reordering #8007
Conversation
There was a problem hiding this comment.
@N-thony I am really pleased you have returned to this issue, because sorting out the reordering of the data frames was one of the last of these operations that seems now to be working.
It seems to be fine, so if @lloyddewit is ok, then I would be happy to merge it.
I am not sure the title of the pull request is totally appropriate though? When I tried, the sheets were reordered as I had wished, and the last sheet always became the active sheet. That's fine by me, but it isn't what I think of as "maintaining the selected sheet".
@rdstern sounds good, it works fine on my side, I have sent some screenshots on Skype |
| @@ -71,7 +71,7 @@ Public MustInherit Class ucrReoGrid | |||
| Return New clsWorksheetAdapter(fillWorkSheet) | |||
| End Function | |||
|
|
|||
| Private Sub ReOrderWorksheets() Implements IGrid.ReOrderWorksheets | |||
| Private Sub ReOrderWorksheets(strCurrWorksheet As String) Implements IGrid.ReOrderWorksheets | |||
There was a problem hiding this comment.
Please could you add a summary header (see comment below)?
There was a problem hiding this comment.
@lloyddewit this is done
|
@lloyddewit I have made the changes, please take a look. Thanks. |
|
@N-thony Thank you for the changes. There is just one open comment above. If you can add the summary header, then we can merge, thanks |
… into reorder_dataframe
There was a problem hiding this comment.
@N-thony Thank you for the final changes.
The new header is the same as the sub name, so it doesn't add any value.
I was hoping that the header would explain more about the what the sub does. However, I looked through the subs again and with the new code comments you added, it's easier for a developer to understand what's happening. So I'm happy to approve/merge.
lloyddewit
changed the title
Fixes #7550
@rdstern as discussed I have improved the code and also fixed the small bug in the
Data Viewto maintain the selected sheet even though reordering is applied. Please, take a look. Thanks.