Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#57 Add more progress bars in the code #58

Merged

Conversation

kkazmierczyk
Copy link
Collaborator

@kkazmierczyk kkazmierczyk commented Nov 29, 2024

Fixes #57

I added progress bars in the console for the following long running actions:
Parsing javacore files
Generating xsls/xmls

image

Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
@kkazmierczyk kkazmierczyk linked an issue Nov 29, 2024 that may be closed by this pull request
@kkazmierczyk kkazmierczyk changed the title Add more progress bars in the co Add more progress bars in the code Nov 29, 2024
@kkazmierczyk kkazmierczyk changed the title Add more progress bars in the code #57 Add more progress bars in the code Dec 3, 2024
@PiotrAniola82
Copy link
Collaborator

PiotrAniola82 commented Dec 6, 2024

This branch fails with error

Exception: Security exception: Uncontrolled data used in path expression
2024-12-06 14:36:12,832 [thread: 28428][ERROR][javacore_analyser_batch.py:101] Processing was not successful. Correct the problem and try again. Exiting with error 13
Traceback (most recent call last):
  File "C:\Users\P40095820\PycharmProjects\javacore-analyser\src\javacore_analyser\javacore_analyser_batch.py", line 98, in main
    process_javacores_and_generate_report_data(files, output_param)
  File "C:\Users\P40095820\PycharmProjects\javacore-analyser\src\javacore_analyser\javacore_analyser_batch.py", line 154, in process_javacores_and_generate_report_data
    javacore_set.generate_report_files(output_dir)
  File "C:\Users\P40095820\PycharmProjects\javacore-analyser\src\javacore_analyser\javacore_set.py", line 129, in generate_report_files
    self.__create_output_files_structure(output_dir)
  File "C:\Users\P40095820\PycharmProjects\javacore-analyser\src\javacore_analyser\javacore_set.py", line 140, in __create_output_files_structure
    raise Exception("Security exception: Uncontrolled data used in path expression")
Exception: Security exception: Uncontrolled data used in path expression

EDIT: this issue is not introduced in this branch. The problem is, due to the way security checks are implemented, the output path on Windows has to use backslashes for path separator, even though forward slashes would otherwise work. Raised issue 69 for this

@PiotrAniola82
Copy link
Collaborator

PiotrAniola82 commented Dec 6, 2024

Also, method def __create_output_files_structure(self, output_dir)
should be static

EDIT:
this method was not introduced in this branch, so created separate issue 68 for this

@PiotrAniola82
Copy link
Collaborator

PiotrAniola82 commented Dec 6, 2024

Furthermore, some progress bars are broken:
Populating snapshot collection: 100%|██████████| 279/279 [00:00<00:00, 3489.45 javacore/s]

EDIT: this only seems to happen in debug mode.

@PiotrAniola82 PiotrAniola82 merged commit 069ecbb into main Dec 6, 2024
6 checks passed
@PiotrAniola82 PiotrAniola82 deleted the 57-add-progress-bars-for-another-expensive-operations branch December 6, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add progress bars for another expensive operations
3 participants