Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14 Implemented progressbars #15

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

kkazmierczyk
Copy link
Collaborator

The code uses tqmd library to track the progress. It is added in parsing javacore files, generating xml/xsls and htmls. These are the most long running operations.

Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
@kkazmierczyk kkazmierczyk added enhancement New feature or request good first issue Good for newcomers labels Oct 28, 2024
@kkazmierczyk kkazmierczyk linked an issue Oct 28, 2024 that may be closed by this pull request
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
@kkazmierczyk
Copy link
Collaborator Author

@PiotrAniola82 @tjanasiewicz any chance to merge this?

@PiotrAniola82
Copy link
Collaborator

Travis builds are failing, so these need to be fixed first

Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
@tjanasiewicz
Copy link
Collaborator

@kkazmierczyk

  1. Is it expected that to be able to execute the JCA from this branch tqmd needs to be installed (pip install tqdm)
  2. Not sure what units are in use, it should be clarified:
    Parsing Javacore files: 100%|██████████| 5/5 [00:06<00:00, 1.24s/it]
  3. Is it expected that even after reaching 100% the entry will not change the color and stay red?

It is not affecting the builds, but I would still like to verify at least the details mentioned above before this request is accepted.

Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
@kkazmierczyk
Copy link
Collaborator Author

kkazmierczyk commented Nov 25, 2024

@tjanasiewicz answers on your questions:

1. Is it expected that to be able to execute the JCA from this branch tqmd needs to be installed (`pip install tqdm`)

Yes. It is added already in requirements.txt

2. Not sure what units are in use, it should be clarified:
   Parsing Javacore files: 100%|██████████| 5/5 [00:06<00:00,  1.24s/**it**]

Good point. I have added it in 2df4ec7

3. Is it expected that even after reaching 100% the entry will not change the color and stay red?

Aparently, this is how this library works. I tried to use parameter colour (/~https://github.com/tqdm/tqdm) but it did not make any effect. I do not know how to change it. However it might depend on the console type. In travis the color is standar one: https://app.travis-ci.com/github/IBM/javacore-analyser/builds/273281736.

@tjanasiewicz tjanasiewicz merged commit 708904a into main Nov 26, 2024
6 checks passed
@tjanasiewicz tjanasiewicz deleted the 14-implement-progress-bars-during-processing branch November 26, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current sprint (10.12) enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement progress bars during processing
3 participants