Restore labels endpoint and embedded app #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplemented the `/model/labels` endpoint and embedded web app lost in the transition to the MAX Framework This update is dependant on the purposed version 1.1.0 of MAX Framework
|
Note that until the other PRs are merged travis will continue to fail |
Cleaned up labels.py: - to pass flake - match the latest maxfw code from the parent PR - simplify code Also added local build dirs to git ignore
|
I just updated the code to match the latest changes in IBM/MAX-Framework#10 |
MLnick
reviewed
Mar 5, 2019
MLnick
approved these changes
Mar 5, 2019
|
This also depends on updating the maxfw in MAX-Base |
|
I've merged the MAX-Base update, but am holding off on cutting a v1.1.1 and updating this until I've fixed Docker for the Max-Base repo (for that repo I will need to manual build each version for back compat). |
|
Pushed the version update, just waiting on Docker Hub's build queue to catch up to run tests |
|
Tests pass, going to merge this a look at cutting a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplemented the
/model/labelsendpoint and embedded web app lost in the transition to the MAX FrameworkThis update is dependent on the purposed version 1.1.0 of MAX Framework found in IBM/MAX-Framework#10 and IBM/MAX-Base#8