Update Dockerfile to pull latest version of web app #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdwyer2 Do we need to bump the version number in this situation? Nothing in this repo has actually changed but the wrapped web app has a major update. |
|
@xuhdev The version bump is needed for the long running instance to pick up the change, but I would say this should be a patch update instead by your reasoning |
ajbozarth
reviewed
Feb 5, 2020
ajbozarth
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Nevermind my previous comments, I should have double checked my own versioning doc first. This definitely qualifies as a minor release not a patch.
LGTM
Edit: https://github.ibm.com/CODAIT/MAX-development-guide/blob/master/VERSIONING.md note any new back combat feature, even though the feature is in the web app since it's included in the build it's valid here.
xuhdev
reviewed
Feb 5, 2020
xuhdev
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this update, we should bump the version number from 1.2 to 1.3.