Add ability to resend code #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, could you please added some tests? |
|
Yes. I should have time to take care of this toward the end of the week. |
| @@ -27,6 +27,11 @@ def update | |||
| end | |||
| end | |||
|
|
|||
| def resend_code | |||
| resource.send_two_factor_authentication_code | |||
| redirect_to user_two_factor_authentication_path, notice: "Your authentication code has been sent." | |||
There was a problem hiding this comment.
What do you think about localizing this notice, so that people can customize it?
|
Planning to merge this anytime soon? |
|
done |
|
@iDiogenes I know this has already been merged, but it would be great if you could please submit a new PR with tests for this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability for a user to resend the auth code from the two_factor_auth page.