Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement bigint output support #700

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: implement bigint output support #700

merged 1 commit into from
Dec 17, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Nov 29, 2024 •
edited
Loading

Acceptance Criteria

  • Remove Node v20 from CI.
  • Update InputNumber React component to use BigInt instead of Number.
  • Update literals (from 123 to 123n).

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@glevco glevco self-assigned this Nov 29, 2024
glevco
glevco commented Nov 29, 2024
View reviewed changes
@glevco glevco marked this pull request as ready for review November 29, 2024 20:59
@glevco glevco changed the title feat: bigint feat: implement bigint output support Nov 29, 2024
pedroferreira1
pedroferreira1 previously approved these changes Dec 4, 2024
View reviewed changes
r4mmer
r4mmer previously approved these changes Dec 9, 2024
View reviewed changes
@glevco glevco force-pushed the refactor/improve-amount-handling branch 2 times, most recently from 37e1601 to c8ec1b3 Compare December 12, 2024 20:00
Base automatically changed from refactor/improve-amount-handling to master December 12, 2024 20:03
@glevco glevco dismissed stale reviews from r4mmer and pedroferreira1 December 12, 2024 20:03

The base branch was changed.

@glevco glevco merged commit 1b9c743 into master Dec 17, 2024
2 checks passed
@glevco glevco deleted the feat/bigint branch December 17, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@r4mmer r4mmer r4mmer approved these changes

Assignees

@glevco glevco

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glevco @pedroferreira1 @r4mmer