Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allTokens variable is a list, not an object #690

Merged
merged 3 commits into from
Nov 12, 2024
Merged

fix: allTokens variable is a list, not an object #690

merged 3 commits into from
Nov 12, 2024

Conversation

pedroferreira1
Copy link
Member

@pedroferreira1 pedroferreira1 commented Nov 12, 2024 •
edited
Loading

Acceptance Criteria

  • Correctly load custom token balances when starting the wallet

This bug was introduced in this refactor: #587

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 self-assigned this Nov 12, 2024
pedroferreira1
pedroferreira1 commented Nov 12, 2024
View reviewed changes
@pedroferreira1 pedroferreira1 merged commit 687ea3d into master Nov 12, 2024
1 check passed
@pedroferreira1 pedroferreira1 deleted the fix/load-custom-token-balance branch November 12, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliomir tuliomir tuliomir approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@pedroferreira1 pedroferreira1

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedroferreira1 @tuliomir @andreabadesso