Fix Jiles-Atherton-based inductor/transformer model #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add tests to ensure they don't bit-rot again.
martinholters
force-pushed
the
mh/fix_ja
branch
from
3a5031b to
edaf246
Compare
|
Updated the tests to at least make sure the small-signal behavior is close to a linear inductor/transformer. On the plus side, this also covers the linear inductor/transformer, which previously also was not tested. However, it still does not verify that the nonlinear behavior is reasonable. I'm afraid that's as good as it get for the moment, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what you get from insufficient test coverage... These were broken since (at least) v0.8.0 / Julia 1.0. Fix is pretty straight-forward, but the new tests mainly make sure the model does something which is at least somewhat reasonable, but might not be anywhere close to the desired behavior.