Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression during rebase in #421 #482

Conversation

tiwatsuka
Copy link
Contributor

@tiwatsuka tiwatsuka commented Mar 5, 2024

Pull Request

Summary

This PR fixes regression that is occurred during rebasing accidentally in #421.
( The change at #421 (comment) have been lost. )

Changes

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No.

Is this a breaking change?

No.

Signed-off-by: Takuya Iwatsuka <takuya.iwatsuka@gmail.com>
@tiwatsuka tiwatsuka requested a review from vaughanknight as a code owner March 5, 2024 09:37
@tiwatsuka
Copy link
Contributor Author

@vaughanknight @danuw I'm sorry to bother you, but I would appreciate if you could check and merge this PR.

Copy link
Collaborator

@danuw danuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danuw danuw merged commit c3f9509 into Green-Software-Foundation:vnext/dotnet8-upgrade Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants