-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gae): rename regions in standard/multitenancy #13047
chore(gae): rename regions in standard/multitenancy #13047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:
This pull request, chore(gae): rename regions in standard/multitenancy, aims to rename regions within the Google App Engine standard/multitenancy samples. The intent is to improve consistency and clarity. The changes are as follows:
- Files Modified:
appengine/standard/multitenancy/datastore.py
appengine/standard/multitenancy/memcache.py
appengine/standard/multitenancy/taskqueue.py
- Changes: The primary change involves renaming the code sections marked with
# [START all]
and# [END all]
to# [START gae_multitenancy_*]
and# [END gae_multitenancy_*]
respectively, where*
represents the specific service (datastore, memcache, taskqueue). This change is consistent across all three files mentioned above. The line numbers affected are 22 and 76 indatastore.py
, 22 and 59 inmemcache.py
, and 22 and 94 intaskqueue.py
.
The author, eapl-gemugami, has indicated that this addresses internal issue b/388924988 and has completed the provided checklist.
Here's a little haiku to lighten the mood:
Code flows like a stream,
Names changed, a clearer view,
Reviews make it shine.
Thanks!
Gemini
Gemini encountered an error creating the review. You can try again by commenting |
You are about to delete the following frozen region tags.
Here is the summary of changes. You are about to add 3 region tags.
You are about to delete 3 region tags.This comment is generated by snippet-bot.
|
Description
Fixes Internal: b/388924988
Checklist
nox -s lint
(see Test Environment Setup)