Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gae): rename regions in standard/multitenancy #13047

Conversation

eapl-gemugami
Copy link
Contributor

Description

Fixes Internal: b/388924988

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 10, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, chore(gae): rename regions in standard/multitenancy, aims to rename regions within the Google App Engine standard/multitenancy samples. The intent is to improve consistency and clarity. The changes are as follows:

  • Files Modified:
    • appengine/standard/multitenancy/datastore.py
    • appengine/standard/multitenancy/memcache.py
    • appengine/standard/multitenancy/taskqueue.py
  • Changes: The primary change involves renaming the code sections marked with # [START all] and # [END all] to # [START gae_multitenancy_*] and # [END gae_multitenancy_*] respectively, where * represents the specific service (datastore, memcache, taskqueue). This change is consistent across all three files mentioned above. The line numbers affected are 22 and 76 in datastore.py, 22 and 59 in memcache.py, and 22 and 94 in taskqueue.py.

The author, eapl-gemugami, has indicated that this addresses internal issue b/388924988 and has completed the provided checklist.


Here's a little haiku to lighten the mood:

Code flows like a stream,
Names changed, a clearer view,
Reviews make it shine.

Thanks!
Gemini

@product-auto-label product-auto-label bot added the api: appengine Issues related to the App Engine Admin API API. label Jan 10, 2025
@eapl-gemugami eapl-gemugami added snippet-bot:force-run Force snippet-bot runs its logic and removed api: appengine Issues related to the App Engine Admin API API. labels Jan 10, 2025
Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 10, 2025
Copy link

snippet-bot bot commented Jan 10, 2025

You are about to delete the following frozen region tags.

Here is the summary of changes.

You are about to add 3 region tags.
You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
/~https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@eapl-gemugami eapl-gemugami marked this pull request as ready for review January 10, 2025 15:36
@eapl-gemugami eapl-gemugami requested review from a team as code owners January 10, 2025 15:36
@engelke engelke merged commit c593c69 into GoogleCloudPlatform:main Jan 10, 2025
11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/chore/gae/rename-regions-in-standard-multitenancy branch January 10, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants