-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create region security policies rules #8477
Create region security policies rules #8477
Conversation
…icy_ddos_protection_config
…-security-services-and-policies
…-security-services-and-policies
…sts for network_edge_security_service
…-security-services-and-policies
…-security-services-and-policies
…security policy rule
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 413 insertions(+), 1 deletion(-)) |
Hi @zli82016 the code is ready to review again. I put this PR in draft mode to avoid merge for now since the user_defined_fields will be public available in few days. The idea is to let this PR ready for merge once it happens so then I move to "wip" again. |
Tests analyticsTotal tests:
|
…ity-policies-rules
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 413 insertions(+), 1 deletion(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_region_security_policy" "primary" {
user_defined_fields {
base = # value needed
mask = # value needed
name = # value needed
offset = # value needed
size = # value needed
}
}
Resource: resource "google_compute_region_security_policy_rule" "primary" {
action = # value needed
description = # value needed
match {
config {
src_ip_ranges = # value needed
}
versioned_expr = # value needed
}
network_match {
dest_ip_ranges = # value needed
dest_ports = # value needed
ip_protocols = # value needed
src_asns = # value needed
src_ip_ranges = # value needed
src_ports = # value needed
src_region_codes = # value needed
user_defined_fields {
name = # value needed
values = # value needed
}
}
preview = # value needed
priority = # value needed
region = # value needed
security_policy = # value needed
}
|
Tests analyticsTotal tests:
|
@zli82016 These features has been moved to "public". Could you please continue the review? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 413 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleNetworkMatchUpdate|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleBasicUpdate|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleMultipleRulesExample|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleBasicExample |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
* creating first version of region security policy and adding ddos protection config * adding rules field in region security policy * creating resource network_edge_security_service and their scenarios of test * adding patch operation and fixing id, import_format and self_link * added fields in the region_security_policy, and fixed the scenario tests for network_edge_security_service * removed duplicated field for region_security_policy * adding ddos_protection_config field in region_security_policy * cleanups * adding self_link field back and removing uncessary fields * adding docs for ddosProtection * making new resources only availabe in beta downstream * fixing eof * adding region security policy rule and basic scenario * code experiments cleanups * adding preconfiguredWafConfig object and some inner fields in region security policy rule * adding mapping for network_match object in region security policy rule * adding rateLimitOptions mapping * adding ruleNumber field to region security policy * adding basic update for region security policy rule * adding network_match and preconfigured_waf scenarios for region sec policy rules * wip - adding user_defined_fields in region security policy * fixing yaml linter issues * fixing review comments * removing validate_only field * fixing comments in region_security_policy_rule test * fixing userDefinedFields and adding tests for regionSecPolicyRule * adding user_defined_fields update test for regionSecPolicy * removing rule_number from regionSecPolicyRule * removing preconfiguredWaf from regionSecPolicyRule because it is not finished yet * removing rateLimitOptions from RegionSecPolicyRule because it is not finished yet * small cleanups * fixing yamllint issues on the worked resources * prevent that netwrokt_match test fails due paralellism * adding new test for multiple rules * fixing code review comments * removing harcoded project from tests * moving network_edge_security_service basic test to another region * fixing code review issues * fixing import cycle issue in downstream repo * updating with upstream and change regions --------- Co-authored-by: diogoEsteves <diogoesteves@ciandt.com>
* creating first version of region security policy and adding ddos protection config * adding rules field in region security policy * creating resource network_edge_security_service and their scenarios of test * adding patch operation and fixing id, import_format and self_link * added fields in the region_security_policy, and fixed the scenario tests for network_edge_security_service * removed duplicated field for region_security_policy * adding ddos_protection_config field in region_security_policy * cleanups * adding self_link field back and removing uncessary fields * adding docs for ddosProtection * making new resources only availabe in beta downstream * fixing eof * adding region security policy rule and basic scenario * code experiments cleanups * adding preconfiguredWafConfig object and some inner fields in region security policy rule * adding mapping for network_match object in region security policy rule * adding rateLimitOptions mapping * adding ruleNumber field to region security policy * adding basic update for region security policy rule * adding network_match and preconfigured_waf scenarios for region sec policy rules * wip - adding user_defined_fields in region security policy * fixing yaml linter issues * fixing review comments * removing validate_only field * fixing comments in region_security_policy_rule test * fixing userDefinedFields and adding tests for regionSecPolicyRule * adding user_defined_fields update test for regionSecPolicy * removing rule_number from regionSecPolicyRule * removing preconfiguredWaf from regionSecPolicyRule because it is not finished yet * removing rateLimitOptions from RegionSecPolicyRule because it is not finished yet * small cleanups * fixing yamllint issues on the worked resources * prevent that netwrokt_match test fails due paralellism * adding new test for multiple rules * fixing code review comments * removing harcoded project from tests * moving network_edge_security_service basic test to another region * fixing code review issues * fixing import cycle issue in downstream repo * updating with upstream and change regions --------- Co-authored-by: diogoEsteves <diogoesteves@ciandt.com>
* creating first version of region security policy and adding ddos protection config * adding rules field in region security policy * creating resource network_edge_security_service and their scenarios of test * adding patch operation and fixing id, import_format and self_link * added fields in the region_security_policy, and fixed the scenario tests for network_edge_security_service * removed duplicated field for region_security_policy * adding ddos_protection_config field in region_security_policy * cleanups * adding self_link field back and removing uncessary fields * adding docs for ddosProtection * making new resources only availabe in beta downstream * fixing eof * adding region security policy rule and basic scenario * code experiments cleanups * adding preconfiguredWafConfig object and some inner fields in region security policy rule * adding mapping for network_match object in region security policy rule * adding rateLimitOptions mapping * adding ruleNumber field to region security policy * adding basic update for region security policy rule * adding network_match and preconfigured_waf scenarios for region sec policy rules * wip - adding user_defined_fields in region security policy * fixing yaml linter issues * fixing review comments * removing validate_only field * fixing comments in region_security_policy_rule test * fixing userDefinedFields and adding tests for regionSecPolicyRule * adding user_defined_fields update test for regionSecPolicy * removing rule_number from regionSecPolicyRule * removing preconfiguredWaf from regionSecPolicyRule because it is not finished yet * removing rateLimitOptions from RegionSecPolicyRule because it is not finished yet * small cleanups * fixing yamllint issues on the worked resources * prevent that netwrokt_match test fails due paralellism * adding new test for multiple rules * fixing code review comments * removing harcoded project from tests * moving network_edge_security_service basic test to another region * fixing code review issues * fixing import cycle issue in downstream repo * updating with upstream and change regions --------- Co-authored-by: diogoEsteves <diogoesteves@ciandt.com>
* creating first version of region security policy and adding ddos protection config * adding rules field in region security policy * creating resource network_edge_security_service and their scenarios of test * adding patch operation and fixing id, import_format and self_link * added fields in the region_security_policy, and fixed the scenario tests for network_edge_security_service * removed duplicated field for region_security_policy * adding ddos_protection_config field in region_security_policy * cleanups * adding self_link field back and removing uncessary fields * adding docs for ddosProtection * making new resources only availabe in beta downstream * fixing eof * adding region security policy rule and basic scenario * code experiments cleanups * adding preconfiguredWafConfig object and some inner fields in region security policy rule * adding mapping for network_match object in region security policy rule * adding rateLimitOptions mapping * adding ruleNumber field to region security policy * adding basic update for region security policy rule * adding network_match and preconfigured_waf scenarios for region sec policy rules * wip - adding user_defined_fields in region security policy * fixing yaml linter issues * fixing review comments * removing validate_only field * fixing comments in region_security_policy_rule test * fixing userDefinedFields and adding tests for regionSecPolicyRule * adding user_defined_fields update test for regionSecPolicy * removing rule_number from regionSecPolicyRule * removing preconfiguredWaf from regionSecPolicyRule because it is not finished yet * removing rateLimitOptions from RegionSecPolicyRule because it is not finished yet * small cleanups * fixing yamllint issues on the worked resources * prevent that netwrokt_match test fails due paralellism * adding new test for multiple rules * fixing code review comments * removing harcoded project from tests * moving network_edge_security_service basic test to another region * fixing code review issues * fixing import cycle issue in downstream repo * updating with upstream and change regions --------- Co-authored-by: diogoEsteves <diogoesteves@ciandt.com>
Fixes:
hashicorp/terraform-provider-google#15319
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)