Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CV user guide page #8135

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Conversation

SarahFrench
Copy link
Contributor

Adding user guide

Release Note Template for Downstream PRs (will be copied)


@SarahFrench SarahFrench requested a review from megan07 June 12, 2023 20:05
@SarahFrench
Copy link
Contributor Author

SarahFrench commented Jun 12, 2023

@megan07 this URL https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/common_issues is made from the file name of mmv1/third_party/terraform/website/docs/guides/common_issues.html.markdown.

I need to ensure the guide from this PR has the URL https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/google-continuous-validation so I named the file in this PR to match that URL.

That seem ok? 😬

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 223 insertions(+))
Terraform Beta: Diff ( 1 file changed, 223 insertions(+))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@SarahFrench SarahFrench merged commit cd276f5 into GoogleCloudPlatform:main Jun 12, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
* Add CV guide page

* Fix h2 headers in markdown

* Fix HCL formatting

* Fix name of `plantimestamp` function
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
* Add CV guide page

* Fix h2 headers in markdown

* Fix HCL formatting

* Fix name of `plantimestamp` function
@SarahFrench SarahFrench deleted the add-cv-guide branch March 26, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants