-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CloudSQL instance point-in-time recovery for selected DBs #7522
Add support for CloudSQL instance point-in-time recovery for selected DBs #7522
Conversation
… DBs add test fix code
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 73 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccNetworkServicesGateway_update|TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic|TestAccDataSourceDnsManagedZone_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question on readability of the field
@@ -1200,8 +1208,15 @@ func expandCloneContext(configured []interface{}) (*sqladmin.CloneContext, strin | |||
|
|||
_cloneConfiguration := configured[0].(map[string]interface{}) | |||
|
|||
databaseNames := []string{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to read this field from the API? If so, it should be present in the flatten function for this field also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. This field should follow the same pattern as point_in_time
field, which is not read from the API.
… DBs (GoogleCloudPlatform#7522) add test fix code
This change is regarding following feature ask #13903
Introducing terraform support of single-database-recovery for SQL Server PITR with
--database_names
option.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)