workbench: Fix a bug with instance metadata being removed not working as expected

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: Fix a bug with instance metadata being removed not working as expected

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 21
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_updateMetadata
• TestAccWorkbenchInstance_updateMetadataKey

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 21
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_updateMetadata
• TestAccWorkbenchInstance_updateMetadataKey

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 21
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_updateMetadata
• TestAccWorkbenchInstance_updateMetadataKey

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_updateMetadata [Error message] [Debug log]
TestAccWorkbenchInstance_updateMetadataKey [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))

[melinath]

looks reasonable & has tests that are passing. Just a couple small requests and questions.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccWorkbenchInstance_updateMetadataKey
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccWorkbenchInstance_updateMetadataKey
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccWorkbenchInstance_updateMetadataKey
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccWorkbenchInstance_updateMetadataKey
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 113 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 113 insertions(+), 13 deletions(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 113 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 113 insertions(+), 13 deletions(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

🟢 All tests passed!

View the build log