Add NetworkTier for GlobalForwardingRule.

[marcinpilat]

Adds a NetworkTier for GlobalForwardingRule.

Fixes hashicorp/terraform-provider-google#20514

Release Note Template for Downstream PRs (will be copied)

compute: added `network_tier` field to `google_compute_global_forwarding_rule` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 50 insertions(+))
google-beta provider: Diff ( 3 files changed, 50 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Tests analytics

Total tests: 1070
Passed tests: 996
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[slevenick]

Can you set this to the non-default value in this test? Just to make sure we can set to something that's not PREMIUM

[marcinpilat]

Default is more complex here - PREMIUM in general is default for global ForwardingRules unless someone has project defined STANDARD network tier. STANDARD is not allowed for global ForwardingRules, so if someone has this per-project setting, then effectively cannot use terraform to setup global FRs.

This also is a reason why we cannot specify here other tier than PREMIUM.

I was considering two options:

• Mimic API and just add networkTier to global FR (so users can set PREMIUM explicitly), or
• Add custom code for terraform that would always set PREMIUM as networkTier.

[slevenick]

If that's the case, why add this field at all to Terraform?

[slevenick]

Talked offline, this is only applicable for STANDARD projects that need to specify PREMIUM to be able to create a GFR. We don't have access to these for testing