Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle operation for ApigeeOrganization delete requests. #12416

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

masich
Copy link
Contributor

@masich masich commented Nov 22, 2024

This PR adds Operation handling to track the ApigeeOrganization deletion progress.

According to the ApigeeOrganization public docs for the delete request, the result of such a request is Operation. However, the provider does not correctly process the delete response, immediately logging Finished deleting Organization. Deletion operation may take a while, and immediately telling users that deletion is completed needs to be corrected.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

apigee: made `google_apigee_organization` wait for deletion operation to complete.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+))
google-beta provider: Diff ( 1 file changed, 8 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 0
Skipped tests: 34
Affected tests: 17

Click here to see the affected service packages
  • apigee

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeAddonsConfig_apigeeAddonsTestExample
  • TestAccApigeeDeveloper_apigeeDeveloperUpdateTest
  • TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample
  • TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample
  • TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update
  • TestAccApigeeEnvironmentIamBindingGenerated
  • TestAccApigeeEnvironmentIamMemberGenerated
  • TestAccApigeeEnvironmentIamPolicyGenerated
  • TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesBetaTestExample
  • TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesTestExample
  • TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsBetaTestExample
  • TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsTestExample
  • TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest
  • TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample
  • TestAccApigeeSyncAuthorization_update
  • TestAccApigeeTargetServer_apigeeTargetServerTestExample
  • TestAccApigeeTargetServer_apigeeTargetServerTest_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApigeeAddonsConfig_apigeeAddonsTestExample [Debug log]
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample [Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample [Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update [Debug log]
TestAccApigeeEnvironmentIamBindingGenerated [Debug log]
TestAccApigeeEnvironmentIamMemberGenerated [Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated [Debug log]
TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesBetaTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsTestExample [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Debug log]
TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample [Debug log]
TestAccApigeeSyncAuthorization_update [Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTestExample [Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTest_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsBetaTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants