-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SQL Server Switchover (after resolving email rebase conflicts) #12241
Support SQL Server Switchover (after resolving email rebase conflicts) #12241
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This pull request was copied over from #11850, which faced issues rebasing to update one commit's email address |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_sql_database_instance" "primary" {
replica_configuration {
ca_certificate = # value needed
client_certificate = # value needed
client_key = # value needed
dump_file_path = # value needed
}
}
|
Tests analyticsTotal tests: 102 Click here to see the affected service packages
Action takenFound 86 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
@@ -178,6 +186,7 @@ func ResourceSqlDatabaseInstance() *schema.Resource { | |||
Type: schema.TypeString, | |||
Optional: true, | |||
Computed: true, | |||
Default: "ENTERPRISE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this must be removed. Was this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_sql_database_instance" "primary" {
replica_configuration {
ca_certificate = # value needed
client_certificate = # value needed
client_key = # value needed
dump_file_path = # value needed
}
}
|
Tests analyticsTotal tests: 102 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
GoogleCloudPlatform#12241) Co-authored-by: Philip Jonany <djpj@google.com>
GoogleCloudPlatform#12241) Co-authored-by: Philip Jonany <djpj@google.com>
Support SQL Server Switchover through terraform
The full design doc can be found in go/sqlserver-switchover-terraform-proposal (Googler-only)
The API changes are rolled out, and my manual testing passes without causing a permadiff