Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong field value example in the iap client resource #11124

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

gecko655
Copy link
Contributor

@gecko655 gecko655 commented Jul 9, 2024

The example in the doc for google_iap_client has a wrong argument field example. The brand field does not have /identityAwareProxyClients/{client_id} part, while the client has that field.

ref: https://cloud.google.com/iap/docs/reference/rest/v1/projects.brands.identityAwareProxyClients/create

brand
Required. Path to create the client in. In the following format: projects/{projectNumber/id}/brands/{brand}

Release Note Template for Downstream PRs (will be copied)


The example in the doc for google_iap_client has a wrong argument field example.
The `brand` field does not have `/identityAwareProxyClients/{client_id}` part, while the client has that field.
Copy link

github-actions bot commented Jul 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from shuyama1 July 9, 2024 11:44
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/iap and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 9, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 85
Passed tests: 65
Skipped tests: 20
Affected tests: 0

Click here to see the affected service packages
  • iap

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping fix the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants