-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong field value example in the iap client resource #11124
Conversation
The example in the doc for google_iap_client has a wrong argument field example. The `brand` field does not have `/identityAwareProxyClients/{client_id}` part, while the client has that field.
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 85 Click here to see the affected service packages
View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping fix the documentation!
The example in the doc for google_iap_client has a wrong argument field example. The
brand
field does not have/identityAwareProxyClients/{client_id}
part, while the client has that field.ref: https://cloud.google.com/iap/docs/reference/rest/v1/projects.brands.identityAwareProxyClients/create
Release Note Template for Downstream PRs (will be copied)