Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove user ID and user email from list_tickets() result #464

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

duwenxin99
Copy link
Contributor

@duwenxin99 duwenxin99 commented Aug 13, 2024

Exposing user ID and email to LLM is unnecessary and we should remove them from list_tickets() results for increased security.

  1. Modify queries to return only necessary columns.
  2. Remove Ticket model validation when returning results from tickets endpoints.

@duwenxin99 duwenxin99 requested a review from a team as a code owner August 13, 2024 20:05
@duwenxin99 duwenxin99 marked this pull request as draft August 14, 2024 13:15
@duwenxin99 duwenxin99 marked this pull request as ready for review August 14, 2024 19:14
@duwenxin99 duwenxin99 requested a review from Yuan325 August 14, 2024 19:18
@duwenxin99 duwenxin99 merged commit 5958938 into main Aug 21, 2024
14 of 15 checks passed
@duwenxin99 duwenxin99 deleted the user_id branch August 21, 2024 17:04
kurtisvg added a commit that referenced this pull request Sep 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](v0.1.0...v0.2.0)
(2024-08-27)


### Features

* Add langgraph orchestration
([#447](#447))
([8cefed0](8cefed0))
* add ticket validation and insertion to cloudsql postgres
([#437](#437))
([a4480fa](a4480fa))
* Add tracing to langgraph orchestration and postgres provider
([#473](#473))
([a5759e9](a5759e9))
* Implement llm system evaluation
([#440](#440))
([a2df60b](a2df60b))
* Remove user ID and user email from `list_tickets()` result
([#464](#464))
([5958938](5958938))


### Bug Fixes

* update pytest to pytest_asyncio for async fixtures
([#474](#474))
([c2ad4bb](c2ad4bb))
* update return from tools for langchain and function calling
([#476](#476))
([9dfb60b](9dfb60b))

---
This PR was generated with [Release
Please](/~https://github.com/googleapis/release-please). See
[documentation](/~https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants