Enable Service mesh feature for ASM to install in GKE #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrarimarco
requested changes
Jun 10, 2022
There was a problem hiding this comment.
Thanks for this PR @laurentgrangeau ! A couple of small nits and we can merge. Thanks!
Update: can you also rebase this branch on the latest main? Thanks for testing those provider updates as well!
Bumps [hashicorp/google-beta](/~https://github.com/hashicorp/terraform-provider-google-beta) from 4.23.0 to 4.24.0. - [Release notes](/~https://github.com/hashicorp/terraform-provider-google-beta/releases) - [Changelog](/~https://github.com/hashicorp/terraform-provider-google-beta/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-google-beta@v4.23.0...v4.24.0) --- updated-dependencies: - dependency-name: hashicorp/google-beta dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [hashicorp/google](/~https://github.com/hashicorp/terraform-provider-google) from 4.23.0 to 4.24.0. - [Release notes](/~https://github.com/hashicorp/terraform-provider-google/releases) - [Changelog](/~https://github.com/hashicorp/terraform-provider-google/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-google@v4.23.0...v4.24.0) --- updated-dependencies: - dependency-name: hashicorp/google dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Should be good now |
ferrarimarco
requested changes
Jun 13, 2022
|
@laurentgrangeau can you also rebase your changes against the latest |
added 3 commits
June 13, 2022 08:11
|
Hi @ferrarimarco everything has been formatted and rebased against |
ferrarimarco
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
@ferrarimarco Can you take a look at it ?