Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set does not work in <IE11 #67

Closed
rdmurphy opened this issue Dec 21, 2018 · 6 comments
Closed

Set does not work in <IE11 #67

rdmurphy opened this issue Dec 21, 2018 · 6 comments
Assignees
Labels
docs Documentation

Comments

@rdmurphy
Copy link

Hello! 👋

Not flagging this to suggest it should work in anything below IE11, but the README currently says quicklink supports IE9+ as long as you have an Intersection Observer polyfill. However Set is not available until IE11. I think a user would need to have a Set polyfill in place to ensure it works that far back?

Apologies if I'm missing something! But wanted to flag just in case.

@tharun208
Copy link

Hi,
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set
By Going through this documentation, You can see that , ie11 doesnot have New Set() options

@addyosmani
Copy link
Collaborator

addyosmani commented Dec 21, 2018

Thanks for filling this issue. We should update the README with a reference to Babel's polyfills, or specifically, importing a shim for Set() to work around this problem for IE9+ users /~https://github.com/zloirock/core-js/blob/master/README.md or
/~https://github.com/paulmillr/es6-shim/blob/master/README.md.

@addyosmani addyosmani self-assigned this Dec 21, 2018
@addyosmani addyosmani added the docs Documentation label Dec 21, 2018
@rdmurphy
Copy link
Author

@addyosmani 👋 After doing another pass I think it may need to mention Array.from too? IE doesn't support it at all, unfortunately.

@tharun208 IE11 is fine with a bare new Set() without parameters (and the other uses of Set in quicklink), it's when you try to pass an interable in it gets mad.

var set = new Set([1, 2, 3]); // IE11 will be upset about this

@addyosmani
Copy link
Collaborator

@rdmurphy 👋 I've just landed aa40490. Could you let me know if there's anything more you think we should add?

@rdmurphy
Copy link
Author

@addyosmani Looks good to me! 🙌

@addyosmani
Copy link
Collaborator

Awesome. Closing this now that it's documented. Cheers! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

No branches or pull requests

3 participants