clients(psi): expose the swapLocale types #14062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build/build-report.js
Outdated
| @@ -96,8 +96,32 @@ async function buildEsModulesBundle() { | |||
| rollupPlugins.commonjs(), | |||
| // Exclude this 30kb from the devtools bundle for now. | |||
| rollupPlugins.shim({ | |||
| [`${LH_ROOT}/shared/localization/i18n-module.js`]: | |||
| 'export const swapLocale = _ => {}; export const format = _ => {};', | |||
| [`${LH_ROOT}/shared/localization/i18n-module.js`]: ` | |||
There was a problem hiding this comment.
Seems ridiculous but I can't think of a better way to do accomplish this. Better to be ridiculous than to overengineer it :)
For readability, would this string be better in a variable than inline? Alternatively should we make a build/shims/ directory and rollupPlugins.alias() i18n-module.js to point there? I'm assuming that would work but it may not
There was a problem hiding this comment.
a shims/i18nmodule.js sg. then it's at least lintable
There was a problem hiding this comment.
i tried a shim file and it's terrible. ends up creating more cruft. so.. leaving as is.
(extracted to a var actually)
adamraine
approved these changes
Jun 1, 2022
adamraine
pushed a commit
that referenced
this pull request
Jun 7, 2022
connorjclark
pushed a commit
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're in a funny situation, so here's the backstory...
node ./node_modules/.bin/tsc --allowJs --declaration --emitDeclarationOnly ./dist/report/bundle.esm.js<== the ESM version!{}for devtools to save 30kb.A more reasonable solution is generating a ~lighthousereportrenderer.types.d.ts file the "right" way.
tsccan generate quality.d.tsfiles - but its 1:1 against source files.There are a few projects that can consume all of those and generate a single file. 1)
dts-genby microsoft is at the module level and doesnt really make sense for this usecase. (probably). 2) dts-generator isn't maintained and dun work. 3) dts-bundle is also dead. 4) dts-bundle-generator seems like the best one, but unfortunately it explicitly doesnt support composite projects. To me, situation is enough justification to justify oursedBS plus this unattractive solution. Ah well, I expect this situation will improve with the arch refactor + dts-bundle-generator adding support.also there's https://api-extractor.com/pages/setup/invoking/ which does this.
an alternative is to only compile with TSC and do declaration emitting. and don't bundle into 1 file, but.. that may not be an option for this reportrenderer case.